roachtest: make cluster settings first class in perturbation tests and allow tests to specify custom spec options #134871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbaptist
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
andrewbaptist
force-pushed
the
2024-11-07-restructure-perturbation
branch
from
6939f15 to
85d664a
Compare
Previously the perturbation test used reflection to determine the set of spec options to use. This change allows each test to customize any options it needs. Epic: none Release note: None
This change makes the cluster settings a first class structure in the perturbation tests. This allows different tests to set the settings how they need when they start. Epic: none Release note: None
andrewbaptist
force-pushed
the
2024-11-07-restructure-perturbation
branch
from
85d664a to
733da73
Compare
kvoli
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @herkolategan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the cluster settings a first class structure in the perturbation tests. This allows different tests to set the settings how they need when they start.
Previously the perturbation test used reflection to determine the set of spec options to use. This change allows each test to customize any options it needs.
Epic: none
Release note: None