crosscluster/logical: check UDT equivalency during LDR creation #133194
Conversation
|
This change is |
rafiss
force-pushed
the
ldr-udt-equivalency
branch
from
0619858 to
7b9c55a
Compare
| dbA.Exec(t, "ALTER TABLE tab ADD COLUMN enum_col mytype NOT NULL") | ||
| dbB.Exec(t, "ALTER TABLE b.tab ADD COLUMN enum_col b.mytype NOT NULL") | ||
| dbA.ExpectErr(t, | ||
| `cannot create logical replication stream: destination table tab column enum_col has user-defined type USER DEFINED ENUM: public.mytype`, | ||
| `cannot create logical replication stream: .* destination type USER DEFINED ENUM: public.mytype has logical representations \[a b c\], but the source type USER DEFINED ENUM: mytype has \[a b\]`, |
There was a problem hiding this comment.
could you also add a test case for composite type mismatch?
| for i, desc := range spec.TypeDescriptors { | ||
| sourceTypes[i] = &desc | ||
| } | ||
| // TODO(rafi): do we need a different type resolver? |
There was a problem hiding this comment.
if the user is using the sql path, we still need to fast fail here until #132164 is resolved.
This check requires that the logical and physical representations of each type are identical. In the future, we may investigate ways to only require logical equivalency. Release note (ops change): When creating a logical replication stream, any user-defined types in the source and destination are now checked for equivalency. This allows for creating a stream that handles user-defined types without needing to use the `WITH SKIP SCHEMA CHECK` option as long as the replication stream uses `mode = immediate`.
rafiss
force-pushed
the
ldr-udt-equivalency
branch
from
7b9c55a to
ea57988
Compare
|
tftr! bors r+ |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-24.3-133194 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/133274/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 24.3.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This check requires that the logical and physical representations of each type are identical. In the future, we may investigate ways to only require logical equivalency.
fixes #132167
Release note (ops change): When creating a logical replication stream,
any user-defined types in the source and destination are now checked for
equivalency. This allows for creating a stream that handles user-defined
types without needing to use the
WITH SKIP SCHEMA CHECKoption as longas the replication stream uses
mode = immediate.