Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosscluster/logical: validate UDT equivalency in LDR planning #132167

Closed
msbutler opened this issue Oct 8, 2024 · 1 comment · Fixed by #133194
Closed

crosscluster/logical: validate UDT equivalency in LDR planning #132167

msbutler opened this issue Oct 8, 2024 · 1 comment · Fixed by #133194
Assignees
Labels
branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@msbutler
Copy link
Collaborator

msbutler commented Oct 8, 2024

When #131130 merges, we will support replication of a table with a UDT if the user in is in yolo mode, i.e. with the SKIP SCHEMA CHECK option. To allow UDT support in general, we need to validate UDT equivalency during LDR planning via the CheckLogicalReplicationCompatibility function, here.

With #131130, the source types will be plumbed to the streampb.ReplicationProducerSpec here.

At first, we should check physical udt equivalency, i.e. color: blue=1, green =2 does not equal color: green=1, blue =2 for now.

Jira issue: CRDB-42861

Epic CRDB-41465

@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Oct 8, 2024
Copy link

blathers-crl bot commented Oct 8, 2024

Hi @benbardin, please add branch-* labels to identify which branch(es) this GA-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants