Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: changefeedccl: protect system.role_members using protected timestamps #131648

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 1, 2024

Backport 1/1 commits from #131027 on behalf of @asg0451.

/cc @cockroachdb/release


Adds system.role_members to the list of system
tables that are protected by changefeeds.

Informs: #128806
See also: #130622

Release note (bug fix): Fix a bug which could
result in changefeeds using cdc queries failing
due to a system table being GC'd.


Release justification: Bug fix for a bug that would prevent users from resuming a CHANGEFEED.

@blathers-crl blathers-crl bot requested a review from a team as a code owner October 1, 2024 06:21
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-131027 branch from bb3814c to c0a6898 Compare October 1, 2024 06:21
@blathers-crl blathers-crl bot requested review from wenyihu6 and removed request for a team October 1, 2024 06:21
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 1, 2024
Copy link
Author

blathers-crl bot commented Oct 1, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 1, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Adds `system.role_members` to the list of system
tables that are protected by changefeeds.

Informs: #128806
See also: #130622

Release note (bug fix): Fix a bug which could
result in changefeeds using cdc queries failing
due to a system table being GC'd.
@stevendanna stevendanna force-pushed the blathers/backport-release-24.1-131027 branch from c0a6898 to e1f2d70 Compare October 1, 2024 09:35
@stevendanna stevendanna merged commit f28dd32 into release-24.1 Oct 17, 2024
19 of 20 checks passed
@stevendanna stevendanna deleted the blathers/backport-release-24.1-131027 branch October 17, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants