changefeedccl: protect system.role_members using protected timestamps

[asg0451]

Adds system.role_members to the list of system
tables that are protected by changefeeds.

Informs: #128806
See also: #130622

Release note (bug fix): Fix a bug which could
result in changefeeds using cdc queries failing
due to a system table being GC'd.

[cockroach-teamcity]

This change is 

[rharding6373]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @asg0451 and @stevendanna)

---

pkg/ccl/changefeedccl/protected_timestamps.go line 53 at r1 (raw file):

	keys.ZonesTableID,
	// Required for CDC Queries.
	// TODO: do we need any other tables, such as `keys.UsersTableID`?

Please add an issue number for this TODO so it doesn't get lost. I'd be in favor of keeping #128806 open to investigate other required tables.

---

pkg/ccl/changefeedccl/protected_timestamps_test.go line 547 at r1 (raw file):

Previously, stevendanna (Steven Danna) wrote…

I wonder if we could make this test less synthetic. Could we instead start a changefeed at a cursor with a cdc expression that should trigger the failure?

The purpose of this test is to validate the effectiveness of the PTS record, so I think using AOST to validate is ok here that it's not GC'd and therefore usable. It seems like there should be a way to turn it into a table-driven test with a case for each protected table, which will make this extendable if we need to protect more tables in the future.

[rharding6373]

Thank you for adding this!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @asg0451 and @stevendanna)

---

-- commits line 7 at r2:
Change this to Informs so the issue doesn't close. Also update the PR's first comment in github.

[asg0451]

bors r=rharding6373

[craig]

Build succeeded:

• linux_amd64_build
• acceptance
• macos_amd64_build
• lint
• examples_orms
• windows_build
• docker_image_amd64
• unit_tests
• local_roachtest_fips
• check_generated_code
• macos_arm64_build
• linux_amd64_fips_build
• linux_arm64_build
• local_roachtest

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from f6472f3 to blathers/backport-release-23.2-131027: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.

---

error creating merge commit from f6472f3 to blathers/backport-release-24.1-131027: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.

---

error creating merge commit from f6472f3 to blathers/backport-release-24.2-131027: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[stevendanna]

blathers backport 24.1 24.2 23.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from f6472f3 to blathers/backport-release-23.2-131027: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}