release-24.2: util/log/logconfig: allow format
for stderr log sink
#131539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #131529.
/cc @cockroachdb/release
Release justification: fix regression
Previously in #113532 we fixed the stderr sink log format to
crdb-v2-tty
. This was deemed to be a regression, as the stderr sink could previously be set to any available format. This commit reverts the restriction.The following are still true after this commit:
format
infile-defaults
is not propagated toformat
of the stderr sink. To setstderr
format, one must explicitly define it in thestderr
sink section of the log config.format-options
infile-defaults
are only applied to stderr if the format of the stderr sink and that in file-defaults are compatible.Epic: none
Fixes: #128665
Release note (ops change): Users may set the log format for the stderr sink by setting the
format
field in the logging config under thestderr
sink section.