util/log/logconfig: allow format for stderr log sink

[xinhaoz]

Previously in #113532 we fixed the stderr sink log format to crdb-v2-tty. This was deemed to be a regression, as the stderr sink could previously be set to any available format. This commit reverts the restriction.

The following are still true after this commit:

• format in file-defaults is not propagated to format of the stderr sink. To set stderr format, one must explicitly define it in the stderr sink section of the log config.
• format-options in file-defaults are only applied to stderr if the format of the stderr sink and that in file-defaults are compatible.

Epic: none
Fixes: #128665

Release note (ops change): Users may set the log format for the stderr sink by setting the format field in the logging config under the stderr sink section.

[cockroach-teamcity]

This change is 

[dhartunian]

Reviewed 1 of 3 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi, @arjunmahishi, @kyle-a-wong, and @xinhaoz)

---

-- commits line 2 at r1:
nit: >

---

-- commits line 22 at r1:
nit space.

---

pkg/util/log/logconfig/testdata/validate line 120 at r1 (raw file):

    filter: NONE
    format-options:
      foo: bar

just for my understanding: why were these propagating prior to this change?

---

pkg/util/log/logconfig/testdata/validate line 295 at r1 (raw file):

  stderr:
    filter: NONE
    format: json

I don't see the format options here

---

pkg/util/log/logconfig/testdata/validate line 322 at r1 (raw file):

    format-options:
      datetime-format: rfc3339
      datetime-timezone: America/New_York

don't we expect the format options to be omitted?

---

pkg/util/log/logconfig/testdata/validate line 366 at r1 (raw file):

  stderr:
    filter: NONE
    format: crdb-v1-tty

can you add a similar test case that uses a non -tty format. I could imagine a restriction where stderr only accepts tty formats.

[xinhaoz]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi, @arjunmahishi, @dhartunian, and @kyle-a-wong)

---

-- commits line 2 at r1:

Previously, dhartunian (David Hartunian) wrote…

nit: >

Removed.

---

-- commits line 22 at r1:

Previously, dhartunian (David Hartunian) wrote…

nit space.

Fixed.

---

pkg/util/log/logconfig/testdata/validate line 295 at r1 (raw file):

Previously, dhartunian (David Hartunian) wrote…

I don't see the format options here

Fixed, see other comment.

---

pkg/util/log/logconfig/testdata/validate line 322 at r1 (raw file):

Previously, dhartunian (David Hartunian) wrote…

don't we expect the format options to be omitted?

Oops I totally flipped the boolean I was supposed to be checking 🤦‍♀️ 🤦‍♀️ Sorry about that, everything should be fixed now.

[dhartunian]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @aa-joshi, @arjunmahishi, @kyle-a-wong, and @xinhaoz)

---

pkg/util/log/logconfig/testdata/validate line 357 at r3 (raw file):

  max-group-size: 100MiB

# Check that stderr can accept format options.

nit: this test is not format option related.

[xinhaoz]

TFTR!
bors r+

[craig]

Build succeeded:

• linux_arm64_build
• linux_amd64_build
• check_generated_code
• lint
• local_roachtest
• windows_build
• unit_tests
• docker_image_amd64
• local_roachtest_fips
• macos_amd64_build
• acceptance
• linux_amd64_fips_build
• macos_arm64_build
• examples_orms