changefeedccl: emit mvcc_timestamp for avro format #129840
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
pkg/ccl/changefeedccl/changefeed_test.go line 1001 at r1 (raw file):
} func TestChangefeedMVCCTimestampsAvro(t *testing.T) {
Nice test!
pkg/ccl/changefeedccl/changefeed_test.go line 1009 at r1 (raw file):
sqlDB.Exec(t, `CREATE TABLE mvcc_timestamp_test_table (id UUID PRIMARY KEY DEFAULT gen_random_uuid())`) rowCount := 5
nit: use const
This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data. Epic: none Fixes: cockroachdb#123078 Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data.
rharding6373
force-pushed
the
20240828_avro_mvcc_timestamp_123078
branch
from
f1365a4 to
597bf39
Compare
|
TFTR! bors r=andyyang890 |
|
blathers backport 24.2 24.1 23.2 |
|
blathers backport 24.1.8-rc |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #123078: branch-release-24.1.8-rc. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data.
Epic: none
Fixes: #123078
Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data.