-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changefeed in Avro format does not include mvcc_timestamp when option is specified #123078
Comments
Just noting we are seeing this with the experimental change feed on Cockroach v23.1.17 as well. |
cc @cockroachdb/cdc |
129840: changefeedccl: emit mvcc_timestamp for avro format r=andyyang890 a=rharding6373 This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data. Epic: none Fixes: #123078 Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data. Co-authored-by: rharding6373 <[email protected]>
This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data. Epic: none Fixes: #123078 Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data.
This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data. Epic: none Fixes: #123078 Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data.
This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data. Epic: none Fixes: #123078 Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data.
Based on the specified backports for linked PR #129840, I applied the following new label(s) to this issue: branch-release-24.1.8-rc. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This PR adds support for the mvcc_timestamp option with the avro format. Before this change, changefeeds using avro would not fail if mvcc_timestamp was specified, but would ignore the option. Now avro supports the mvcc_timestamp by adding mvcc_timestamp to the schema and emitting the mvcc value with the row data. Epic: none Fixes: #123078 Release note (enterprise change): Adds changefeed support for the mvcc_timestamp option with the avro format. If both options are specified, the avro schema includes an mvcc_timestamp metadata field and emits the row's mvcc timestamp with the row data.
Describe the problem
When a changefeed is created using
WITH mvcc_timestamp
and Avro format, the mvcc_timestamp never gets emitted in the message. UsingWITH updated
works for emitting the updated timestamp, butmvcc_timestamp
is required to accurately include the timestamp during an initial scan.To Reproduce
Setup a confluent schema registry.
Run
cockroach demo
.Run the following sinkless changefeed:
Insert a row into the
movr.users
table. Notice that the changefeed message does not have themvcc_timestamp
field.Expected behavior
The
mvcc_timestamp
field is included, similar to how it is included when usingjson
format.Environment:
cockroach sql
Additional context
The only other option is to use the
updated
field, which does not accurately reflect themvcc_timestamp
during initial scan or backfill.Jira issue: CRDB-38190
Epic CRDB-41784
The text was updated successfully, but these errors were encountered: