roachprod: azure GC supports cleanup for multiple subscriptions #129058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DarrylWong
force-pushed
the
azure-multiple-gc
branch
3 times, most recently
from
4788a67 to
a3d4a39
Compare
DarrylWong
requested review from
nameisbhaskar and
renatolabs
and removed request for
a team
|
Actually this won't work because it exposes the subscription ID in the yaml file which according to Dev inf = not good. Will need to take in the subscription name and iterate for the ID instead. (Done) |
DarrylWong
force-pushed
the
azure-multiple-gc
branch
3 times, most recently
from
79834f0 to
7d36bde
Compare
Previously Azure GC assumed that only one subscription ID would be used at a time. However the current structure of our Azure subscriptions makes a distinction between user "adhoc" roachprod clusters and nightly "infra" clusters. As a result, roachprod clusters can live in two different subscriptions. This change adds the azure-subscription-names flag to support cleaning up in multiple Azure subscriptions. Additionally it also switches the default subscription to e2e-adhoc, which is what users should use.
DarrylWong
force-pushed
the
azure-multiple-gc
branch
from
7d36bde to
44a0a3d
Compare
srosenberg
approved these changes
Aug 19, 2024
|
TFTR! bors r=srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Azure GC assumed that only one subscription ID would be used at a time. However the current structure of our Azure subscriptions makes a distinction between user "adhoc" roachprod clusters and nightly "infra" clusters. As a result, roachprod clusters can live in two different subscriptions.
This change adds the azure-subscription-name flag to support cleaning up in multiple subscriptions.
Additionally it also switches the default subscription ID to e2e-adhoc, which is what users should use.
Fixes: #129057
Release note: none
Epic: none