Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachprod gc: enable cluster cleanup for multiple azure subscriptions #129057

Closed
DarrylWong opened this issue Aug 15, 2024 · 1 comment · Fixed by #129058
Closed

roachprod gc: enable cluster cleanup for multiple azure subscriptions #129057

DarrylWong opened this issue Aug 15, 2024 · 1 comment · Fixed by #129058
Assignees
@DarrylWong
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@DarrylWong
Copy link
Contributor

DarrylWong commented Aug 15, 2024 •
edited by cockroach-jira-scripts
Loading

Our azure infrastructure has three main subscriptions used by engineers:

  1. e2e-adhoc: used by engineering to run "adhoc" roachprod/roachtest clusters
  2. e2e-infra: used for roachtest nightlies and test-eng infrastructure
  3. Microsoft Azure Sponsorship: catch all subscription that will be migrated to one of the above two

Currently, roachprod GC can only clean up one Azure subscription at a time, which is not ideal as we have roachprod clusters throughout all three subscriptions. Similar to #110755, we should enable cleanup for multiple Azure subscriptions. This can be done by passing in a list of subscriptionIDs the GC should list clusters from.

Jira issue: CRDB-41358
@DarrylWong DarrylWong added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 15, 2024
@DarrylWong DarrylWong mentioned this issue Aug 15, 2024
Merged
@craig craig bot closed this as completed in 27dc4e6 Aug 20, 2024
@exalate-issue-sync exalate-issue-sync bot added the T-testeng TestEng Team label Aug 30, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Aug 30, 2024

cc @cockroachdb/test-eng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarrylWong DarrylWong

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachprod: azure GC supports cleanup for multiple subscriptions DarrylWong/fork
1 participant
@DarrylWong