Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod gc: enable cluster cleanup for multiple AWS accounts #110755

Closed
jlinder opened this issue Sep 16, 2023 · 1 comment
Closed

roachprod gc: enable cluster cleanup for multiple AWS accounts #110755

jlinder opened this issue Sep 16, 2023 · 1 comment
Assignees
Labels
A-roachprod C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@jlinder
Copy link
Collaborator

jlinder commented Sep 16, 2023

Problem:

roachprod clusters are now (or will be shortly) running in multiple AWS accounts. roachprod gc can only be configured to clean up one AWS account at a time. If roachprod gc is not extended to support cleanup of multiple AWS accounts on each run, then clusters that we want to be cleaned up will continue running and waste money.

Suggested solution:

  1. Change roachprod gc to support cleaning multiple AWS accounts. Ideally, this would be done by providing an API access key pair to a single IAM service account that can assume role into the accounts with clusters to GC and a list of the accounts (as aliases) to assume role into. (A less desirable approach is to provide a list of access key pairs to the command, one per account to be cleaned.)
  2. Change the roachprod-gc scheduled job to use the new feature to clean all the AWS accounts where we create and run roachprod clusters.

Jira issue: CRDB-31591

Epic DEVINF-235

@jlinder jlinder added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-roachprod T-testeng TestEng Team labels Sep 16, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 16, 2023

cc @cockroachdb/test-eng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-roachprod C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants