-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: sql/randgen: do not generate expressions of type FLOAT4 #129010
Conversation
7427ff6
to
fea830e
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There are several known issues with the `FLOAT4` type. Our randomized tests commonly fail due to these issues. They are not trivially fixed, so for now we'll stop generating columns and expressions of type `FLOAT4` in randomized tests. Informs #128296 Release note: None
fea830e
to
e985493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @mgartner)
Backport 1/1 commits from #128988 on behalf of @mgartner.
/cc @cockroachdb/release
There are several known issues with the
FLOAT4
type. Our randomizedtests commonly fail due to these issues. They are not trivially fixed,
so for now we'll stop generating columns and expressions of type
FLOAT4
in randomized tests.Informs #128296
Release note: None
Release justification: Test-only change.