roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #128296

cockroach-teamcity · 2024-08-05T11:20:55Z

roachtest.unoptimized-query-oracle/disable-rules=all/rand-tables failed with artifacts on release-23.1 @ 7748ab2d671c6e8d021af1ca577d2de4578751db:

  	}, ""),
  	strings.Join({
  		"0,0,BOX(-1.3756519703492662 -2.3674107175102392,0.13874195816559",
  		"645 -0.30512778435886845),0.7591851",
+ 		"3536",
  		"4",
+ 		"5325",
  		",true,0,{á,\x7f},0000-01-01 13:53:20 -0800 -0800,a\n,0,àá,0.75918",
  		"514,box(-1.3756519703492662 -2.3674107175102392,0.13874195816559",
  		"645 -0.30512778435886845)",
  	}, ""),
  	strings.Join({
  		"0,0,BOX(-1.449584199380424 -2.752369575975844,-0.046069656464325",
  		"814 1.1820923515631292),1.2345679",
+ 		"166470003",
  		"e-11,true,0,{á,\x7f},0000-01-01 02:04:52.036316 -0800 -0800,a\n,0,\xc3",
  		"\xa0á,1.2345679e-11,box(-1.449584199380424 -2.752369575975844,-0.0",
  		"46069656464325814 1.1820923515631292)",
  	}, ""),
  	strings.Join({
  		"0,0,BOX(-1.5003830675236967 -0.08751471293645777,-1.178868515909",
  		"9428 0.9747771507015268),1.07993",
- 		"2",
+ 		"19744110107",
  		",false,0,{*,0,\x15},0000-01-01 13:32:12.535169 -1028 -1028,a\n,0,à\xc3",
  		"\xa1,-1.079932,box(-1.5003830675236967 -0.08751471293645777,-1.1788",
  		"685159099428 0.9747771507015268)",
  	}, ""),
  	... // 6 identical and 123 modified elements
  }
sql: SELECT
	tab_164.col2_8 AS col_465,
	tab_164.col2_7 AS col_466,
	tab_164."col2 _1" AS col_467,
	tab_164.col2_16 AS col_468,
	tab_164."col2_ 2" AS col_469,
	tab_164.col2_6 AS col_470,
	tab_164.col2_0 AS col_471,
	tab_164.col2_11 AS col_472,
	e'a\n':::STRING AS col_473,
	tab_164.col2_17 AS col_474,
	e'\u00E0\u00E1':::STRING AS col_475,
	tab_164."col \\u5B952_5" AS col_476,
	tab_164.col2_15 AS col_477
FROM
	defaultdb.public."t\\x83able2"@[0] AS tab_164
ORDER BY
	tab_164."col2_ 2", tab_164."""col2_
4" NULLS LAST, tab_164.tableoid ASC NULLS FIRST
test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=all/rand-tables/cpu_arch=arm64/run_1

Parameters:

ROACHTEST_arch=arm64
ROACHTEST_cloud=gce
ROACHTEST_cpu=4
ROACHTEST_encrypted=false
ROACHTEST_metamorphicBuild=false
ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

sql: incorrect cast of REGCLASS types in vectorized engine #128294 roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed [C-test-failure O-roachtest O-robot O-rsg T-sql-queries branch-master release-blocker]

_{This test on roachdash | Improve this report!

Jira issue: CRDB-40927}

The text was updated successfully, but these errors were encountered:

cockroach-teamcity · 2024-08-06T10:46:47Z

roachtest.unoptimized-query-oracle/disable-rules=all/rand-tables failed with artifacts on release-23.1 @ 7748ab2d671c6e8d021af1ca577d2de4578751db:

  		":48B,65A,202B,540C 'VLIsGSn' 'gClgRsTGTw':44B 'kWJvG',a$)(,\U000eb4ee\xf1",
  		"\xb1\xbf\x9b\U0009021c\U0007d29e𦿀,-0.09471096098423004,0.946013",
+ 		"80",
  		"8",
+ 		"2504272",
  		",1.2345678616041472e+31",
  	}, ""),
  	strings.Join({
  		"105,0.94783",
+ 		"00213813782",
  		",-107,24415,0110110011010100,00000000000000000000000000000000,NU",
  		"LL,'K','DjsQzlIeqb':104B,350A,685A,826C 'JrRJl':48B,65A,202B,540",
  		"C 'VLIsGSn' 'gClgRsTGTw':44B 'kWJvG',a$)(,\U000cb1b1\U000ab904,-0.0947109609",
  		"8423004,0.94783",
+ 		"00213813782",
  		",1.2345678616041472e+31",
  	}, ""),
  	strings.Join({
  		"105,0.968167",
+ 		"0069694519",
  		",-107,24415,0110110011010100,00000000000000000000000000000000,NU",
  		"LL,'K','DjsQzlIeqb':104B,350A,685A,826C 'JrRJl':48B,65A,202B,540",
  		"C 'VLIsGSn' 'gClgRsTGTw':44B 'kWJvG',a$)(,\U000d50b0\U0008bb64,-0.0947109609",
  		"8423004,0.968167",
+ 		"0069694519",
  		",1.2345678616041472e+31",
  	}, ""),
  	... // 4 identical and 78 modified elements
  }
sql: SELECT
	tab_412.tableoid AS col_1121,
	tab_412.col2_10 AS col_1122,
	(-107):::INT8 AS col_1123,
	24415:::INT8 AS col_1124,
	B'0110110011010100' AS col_1125,
	B'00000000000000000000000000000000' AS col_1126,
	tab_412.col2_0 AS col_1127,
	'''K''':::TSQUERY AS col_1128,
	'''DjsQzlIeqb'':104B,350A,685A,826C ''JrRJl'':48B,65A,202B,540C ''VLIsGSn'' ''gClgRsTGTw'':44B ''kWJvG''':::TSVECTOR
		AS col_1129,
	'a$)(':::STRING AS col_1130,
	tab_412.col2_4 AS col_1131,
	(-0.09471096098423004):::FLOAT8 AS col_1132,
	tab_412.col2_10 AS col_1133,
	1.2345678616041472e+31:::FLOAT8 AS col_1134
FROM
	defaultdb.public.table2@[0] AS tab_412
ORDER BY
	tab_412.col2_7 NULLS LAST
test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=all/rand-tables/run_1

Parameters:

ROACHTEST_arch=amd64
ROACHTEST_cloud=gce
ROACHTEST_cpu=4
ROACHTEST_encrypted=false
ROACHTEST_metamorphicBuild=false
ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

sql: incorrect cast of REGCLASS types in vectorized engine #128294 roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed [C-test-failure O-roachtest O-robot O-rsg T-sql-queries branch-master release-blocker]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2024-08-09T10:42:25Z

roachtest.unoptimized-query-oracle/disable-rules=all/rand-tables failed with artifacts on release-23.1 @ fc515e47e7f23977cf83f5696102266224c6ff03:

  		"0,0.39179724,0,0.39179724",
+ 		"45487976",
  		``,a	,0.059980183839797974,true,☃,f``,
  	}, ""),
  	strings.Join({
  		"0,0.39179724,0,0.39179724",
+ 		"45487976",
  		``,a	,0.059980183839797974,true,�,f``,
  	}, ""),
  	strings.Join({
  		"0,0.73667896,0,0.7366789",
- 		"6",
+ 		"57939148",
  		``,a	,0.059980183839797974,true,T,f``,
  	}, ""),
  	strings.Join({
  		"0,0.94699967,0,0.9469996",
+ 		"690",
  		"7",
+ 		"50122",
  		``,a	,0.059980183839797974,true,6,f``,
  	}, ""),
  	strings.Join({
  		"0,0.98760915,0,0.9876091",
+ 		"48025",
  		"5",
+ 		"127",
  		``,a	,0.059980183839797974,true,�,f``,
  	}, ""),
  	strings.Join({
  		"0,1.2113987,0,1.2113987",
+ 		"20741272",
  		``,a	,0.059980183839797974,true,',f``,
  	}, ""),
  	... // 1 identical and 59 modified elements
  }
sql: SELECT
	tab_53."col2_
1" AS col_139,
	tab_53.col2_4 AS col_140,
	0:::OID AS col_141,
	tab_53.c😐ol2_5 AS col_142,
	e'a\t':::STRING AS col_143,
	0.059980183839797974:::FLOAT8 AS col_144,
	true AS col_145,
	tab_53.col2_2 AS col_146,
	'f':::STRING AS col_147
FROM
	defaultdb.public.table2@[0] AS tab_53
test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=all/rand-tables/run_1

Parameters:

ROACHTEST_arch=amd64
ROACHTEST_cloud=gce
ROACHTEST_cpu=4
ROACHTEST_encrypted=false
ROACHTEST_metamorphicBuild=false
ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

sql: incorrect cast of REGCLASS types in vectorized engine #128294 roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed [C-test-failure O-roachtest O-robot O-rsg T-sql-queries branch-master release-blocker]

_{This test on roachdash | Improve this report!}

mgartner · 2024-08-14T15:58:20Z

I reduced the first failure to:

CREATE TABLE t (
  b INT4,
  c FLOAT4,
  d FLOAT4 AS (abs(c)) VIRTUAL
);

INSERT INTO t (c, b) VALUES (-1.1445338726043701, 0);

SET testing_optimizer_disable_rule_probability = 1;

SELECT abs(c), d FROM t ORDER BY b NULLS LAST;
--          abs         |     d
-- ---------------------+------------
--   1.1445338726043701 | 1.1445339
-- (1 row)

RESET testing_optimizer_disable_rule_probability;

SELECT abs(c), d FROM t ORDER BY b NULLS LAST;
--          abs         |         d
-- ---------------------+---------------------
--   1.1445338726043701 | 1.1445338726043701
-- (1 row)

All the other failures appear to be the same problem.

mgartner · 2024-08-14T16:13:39Z

The root cause is that we don't correctly store FLOAT4 values, nor do we correctly evaluate expressions on FLOAT4. See #73743 and #48613. This will not be easy to fix. One option to silence the failures is to disable FLOAT4 types in these tests.

There are several known issues with the `FLOAT4` type. Our randomized tests commonly fail due to these issues. They are not trivially fixed, so for now we'll stop generating columns and expressions of type `FLOAT4` in randomized tests. Informs cockroachdb#128296 Release note: None

mgartner · 2024-08-14T20:20:46Z

Interestingly, this does not reproduce on 23.2+. I'll try to hunt down the commit that fixed this.

mgartner · 2024-08-14T20:29:35Z

It looks like #105736 fixed this particular case. I'll backport it to 23.1.

128843: roachtest: fix `admission-control/disk-bandwidth-limiter` on azure r=sumeerbhola a=aadityasondhi The CRDB data mount is different on azure when compared to AWS and GCE. We use `sda1` instead of `data1` in this case. Fixes: #128364. Release note: None 128932: catalog: rename ByID to ByIDWithoutLeased r=rafiss a=rafiss This makes the function name much more clear. Previously, it would be easy to assume that ByID would also include leased descriptors. fixes #99506 Release note: None 128985: kvflowcontrolpb,kvserverpb: add AdmittedResponseForRange r=kvoli a=sumeerbhola For piggybacking a MsgAppResp message from a follower to the leader, to advance admitted. Also, RaftMessageRequest.AdmittedResponse contains these piggybacked messages Informs #128309 Epic: CRDB-37515 Release note: None 128988: sql/randgen: do not generate expressions of type FLOAT4 r=mgartner a=mgartner There are several known issues with the `FLOAT4` type. Our randomized tests commonly fail due to these issues. They are not trivially fixed, so for now we'll stop generating columns and expressions of type `FLOAT4` in randomized tests. Informs #128296 Release note: None Co-authored-by: Aaditya Sondhi <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: sumeerbhola <[email protected]> Co-authored-by: Marcus Gartner <[email protected]>

mgartner · 2024-08-14T20:37:30Z

I'm going to close this as all the bugs mentioned above are tracked by other issues.

There are several known issues with the `FLOAT4` type. Our randomized tests commonly fail due to these issues. They are not trivially fixed, so for now we'll stop generating columns and expressions of type `FLOAT4` in randomized tests. Informs cockroachdb#128296 Release note: None

There are several known issues with the `FLOAT4` type. Our randomized tests commonly fail due to these issues. They are not trivially fixed, so for now we'll stop generating columns and expressions of type `FLOAT4` in randomized tests. Informs #128296 Release note: None

cockroach-teamcity added this to the 23.1 milestone Aug 5, 2024

cockroach-teamcity added this to SQL Queries Aug 5, 2024

github-project-automation bot moved this to Triage in SQL Queries Aug 5, 2024

mgartner mentioned this issue Aug 14, 2024

sql/randgen: do not generate expressions of type FLOAT4 #128988

Merged

mgartner mentioned this issue Aug 14, 2024

roachtest: unoptimized-query-oracle/disable-rules=half/rand-tables failed #126802

Closed

mgartner closed this as completed Aug 14, 2024

github-project-automation bot moved this from Triage to Done in SQL Queries Aug 14, 2024

blathers-crl bot mentioned this issue Aug 14, 2024

release-23.2: sql/randgen: do not generate expressions of type FLOAT4 #129010

Merged

blathers-crl bot mentioned this issue Aug 14, 2024

release-24.1: sql/randgen: do not generate expressions of type FLOAT4 #129011

Merged

blathers-crl bot mentioned this issue Aug 14, 2024

release-24.2: sql/randgen: do not generate expressions of type FLOAT4 #129012

Merged

mgartner mentioned this issue Aug 14, 2024

release-23.1: sql/randgen: do not generate expressions of type FLOAT4 #129014

Merged

mgartner mentioned this issue Aug 15, 2024

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #129030

Closed

blathers-crl bot mentioned this issue Aug 15, 2024

release-23.1.25-rc: sql/randgen: do not generate expressions of type FLOAT4 #129082

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #128296

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #128296

cockroach-teamcity commented Aug 5, 2024 •

edited by cockroach-jira-scripts

Loading

cockroach-teamcity commented Aug 6, 2024

cockroach-teamcity commented Aug 9, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #128296

roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed #128296

Comments

cockroach-teamcity commented Aug 5, 2024 • edited by cockroach-jira-scripts Loading

cockroach-teamcity commented Aug 6, 2024

cockroach-teamcity commented Aug 9, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

mgartner commented Aug 14, 2024

cockroach-teamcity commented Aug 5, 2024 •

edited by cockroach-jira-scripts

Loading