Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.2: roachtest: fix multi-store-remove #127070

Merged
merged 1 commit into from
Sep 11, 2024
Merged

release-24.2: roachtest: fix multi-store-remove #127070

merged 1 commit into from
Sep 11, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 12, 2024

Backport 1/1 commits from #127041 on behalf of @nicktrav.

/cc @cockroachdb/release

The intention of the test is to compare the number of ranges (multiplied by the replication factor) to the sum of replicas across all stores. The current implementation is incorrect, as it compares range count to store count.

Fix the test by using a sum of replicas across each store, rather than a count, which will return the number of stores.

Fix #123989.

Release note: None.

Release justification:

@nicktrav
roachtest: fix multi-store-remove
054538f 
The intention of the test is to compare the number of ranges (multiplied
by the replication factor) to the _sum_ of replicas across all stores.
The current implementation is incorrect, as it compares range count to
store count.

Fix the test by using a `sum` of replicas across each store, rather than
a `count`, which will return the number of stores.

Fix #123989.

Release note: None.
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 12, 2024 15:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-127041 branch from 29d7934 to 054538f Compare July 12, 2024 15:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 12, 2024
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Jul 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 12, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

itsbilal
itsbilal approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Reminder: it has been 3 weeks please merge or close your backport!

@nicktrav nicktrav merged commit 1f44847 into release-24.2 Sep 11, 2024
19 of 20 checks passed
@nicktrav nicktrav deleted the blathers/backport-release-24.2-127041 branch September 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsbilal itsbilal itsbilal approved these changes

@nameisbhaskar nameisbhaskar Awaiting requested review from nameisbhaskar

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@nicktrav nicktrav

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @itsbilal @nicktrav