Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix multi-store-remove #127041

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

nicktrav
Copy link
Collaborator

The intention of the test is to compare the number of ranges (multiplied by the replication factor) to the sum of replicas across all stores. The current implementation is incorrect, as it compares range count to store count.

Fix the test by using a sum of replicas across each store, rather than a count, which will return the number of stores.

Fix #123989.

Release note: None.

The intention of the test is to compare the number of ranges (multiplied
by the replication factor) to the _sum_ of replicas across all stores.
The current implementation is incorrect, as it compares range count to
store count.

Fix the test by using a `sum` of replicas across each store, rather than
a `count`, which will return the number of stores.

Fix cockroachdb#123989.

Release note: None.
@nicktrav nicktrav added the backport-24.2.x Flags PRs that need to be backported to 24.2 label Jul 11, 2024
@nicktrav nicktrav requested review from itsbilal and a team July 11, 2024 22:24
@nicktrav nicktrav requested a review from a team as a code owner July 11, 2024 22:24
@nicktrav nicktrav requested review from srosenberg and nameisbhaskar and removed request for a team July 11, 2024 22:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktrav
Copy link
Collaborator Author

TFTR!

bors r=itsbilal

@craig craig bot merged commit 23ab279 into cockroachdb:master Jul 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.2.x Flags PRs that need to be backported to 24.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: multi-store-remove failed
3 participants