roachtest: skip opr_sanity.sql in pg_regress #123652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have incomplete `pg_catalog.pg_proc` contents, so `opr_sanity.sql` subtest results in invalid entries that need to be updated every time when a new builtin function is introduced, which is an unnecessary toil. Let's skip this subtest for now. Epic: None Release note: None
yuzefovich
requested review from
a team and
DrewKimball
and removed request for
a team and
DrewKimball
yuzefovich
requested review from
michae2,
herkolategan and
renatolabs
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
michae2
approved these changes
May 6, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have incomplete
pg_catalog.pg_proccontents, soopr_sanity.sqlsubtest results in invalid entries that need to be updated every time when a new builtin function is introduced, which is an unnecessary toil. Let's skip this subtest for now.Informs: #123401.
Informs: #123651.
Epic: None
Release note: None