Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg_catalog: fix up contents of pg_catalog.pg_proc #123651

Open
yuzefovich opened this issue May 5, 2024 · 0 comments
Open

pg_catalog: fix up contents of pg_catalog.pg_proc #123651

yuzefovich opened this issue May 5, 2024 · 0 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. O-pg-regress Originated from the pg_regress test suite. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented May 5, 2024

Currently, when running opr_sanity.sql subtest of pg_regress test suite, we get lots of rows on queries that should be returning none, indicating that some illegal values / incomplete information is present. For now, in order to avoid unnecessary churn of the pg_regress diff file when adding new builtins, we'll skip opr_sanity.sql altogether.

Jira issue: CRDB-38448

@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-sql-pgcompat Semantic compatibility with PostgreSQL T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) T-sql-queries SQL Queries Team labels May 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries May 5, 2024
@yuzefovich yuzefovich moved this from Triage to Backlog in SQL Queries May 5, 2024
@yuzefovich yuzefovich added the O-pg-regress Originated from the pg_regress test suite. label May 5, 2024
craig bot pushed a commit that referenced this issue May 6, 2024
123652: roachtest: skip opr_sanity.sql in pg_regress r=yuzefovich a=yuzefovich

We currently have incomplete `pg_catalog.pg_proc` contents, so `opr_sanity.sql` subtest results in invalid entries that need to be updated every time when a new builtin function is introduced, which is an unnecessary toil. Let's skip this subtest for now.

Informs: #123401.
Informs: #123651.
Epic: None

Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-queries SQL Queries Team label May 7, 2024
@yuzefovich yuzefovich added the T-sql-queries SQL Queries Team label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. O-pg-regress Originated from the pg_regress test suite. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) T-sql-queries SQL Queries Team
Projects
Status: Backlog
Status: Triage
Development

No branches or pull requests

1 participant