-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: backupccl: copy spans before SubtractSpans calls #122843
Conversation
e29e57a
to
64504df
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
abandoning this as we're taking a different approach to prevent empty external file ingestion |
Backport 1/1 commits from #122819 on behalf of @msbutler.
/cc @cockroachdb/release
Previously, backup assumed arguments to roachpb.SubtractSpans could be used, but the first arg is modified in place. This patch adds a wrapper to roachpb.SubtractSpans to copy the input spans before use.
Informs #122672
Informs #122734
Informs #122754
Informs #122764
Release note: none
Release justification: fixes corruption bug