Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: backup-restore/small-ranges failed #122764

Closed
cockroach-teamcity opened this issue Apr 21, 2024 · 3 comments
Closed

roachtest: backup-restore/small-ranges failed #122764

cockroach-teamcity opened this issue Apr 21, 2024 · 3 comments
Assignees
@msbutler
Labels
branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Apr 21, 2024 •
edited by cockroach-jira-scripts
Loading

roachtest.backup-restore/small-ranges failed with artifacts on release-24.1 @ 3111a51bdb2cbf889c92f4440bf88b0eb682cb96:

(monitor.go:154).Wait: monitor failure: error waiting for job to finish: job 962099754044096514 failed with error: expected previous backups to cover until time 1713679772.041964193,0, got 1713679461.192601248,0 (e.g. span /Table/114/1{-/35/9/2045})
test artifacts and logs in: /artifacts/backup-restore/small-ranges/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=true
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-38052
@cockroach-teamcity cockroach-teamcity added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Apr 21, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Apr 21, 2024
@cockroach-teamcity cockroach-teamcity mentioned this issue Apr 21, 2024
Closed
@msbutler
Copy link
Collaborator

A cluster restore attempt failed on checkFiles error on a backup with revision history.

@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Apr 22, 2024
msbutler added a commit to msbutler/cockroach that referenced this issue Apr 22, 2024
@msbutler
backupccl: copy spans before SubtractSpans calls
b037095 
Previously, backup assumed arguments to roachpb.SubtractSpans could be used,
but the first arg is modified in place. This patch adds a wrapper to
roachpb.SubtractSpans to copy the input spans before use.

Informs cockroachdb#122672
Informs cockroachdb#122734
Informs cockroachdb#122754
Informs cockroachdb#122764

Release note: none
@msbutler msbutler mentioned this issue Apr 22, 2024
Merged
craig bot pushed a commit that referenced this issue Apr 22, 2024
@msbutler
Merge #122819
d679773 
122819: backupccl: copy spans before SubtractSpans calls r=dt a=msbutler

Previously, backup assumed arguments to roachpb.SubtractSpans could be used, but the first arg is modified in place. This patch adds a wrapper to roachpb.SubtractSpans to copy the input spans before use.

Informs #122672
Informs #122734
Informs #122754
Informs #122764

Release note: none

Co-authored-by: Michael Butler <[email protected]>
blathers-crl bot pushed a commit that referenced this issue Apr 22, 2024
@msbutler
backupccl: copy spans before SubtractSpans calls
64504df 
Previously, backup assumed arguments to roachpb.SubtractSpans could be used,
but the first arg is modified in place. This patch adds a wrapper to
roachpb.SubtractSpans to copy the input spans before use.

Informs #122672
Informs #122734
Informs #122754
Informs #122764

Release note: none
@blathers-crl blathers-crl bot mentioned this issue Apr 22, 2024
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.backup-restore/small-ranges failed with artifacts on release-24.1 @ 25b56cd17fadb50ab6e37e71870f2ff65e46a4d5:

(test_runner.go:1198).runTest: test timed out (4h0m0s)
test artifacts and logs in: /artifacts/backup-restore/small-ranges/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

This test on roachdash | Improve this report!

@msbutler
Copy link
Collaborator

Fixed via #122774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbutler msbutler

Labels
branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Status: Done
Milestone
24.1
Development

No branches or pull requests
2 participants
@cockroach-teamcity @msbutler