Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: run rebalance/by-load/*/mixed-version on insecure mode #122187

Merged
merged 1 commit into from
Apr 11, 2024
Merged

roachtest: run rebalance/by-load/*/mixed-version on insecure mode #122187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/cmd/roachtest/tests/rebalance_load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,15 @@ func registerRebalanceLoad(r registry.Registry) {

if mixedVersion {
mvt := mixedversion.NewTest(ctx, t, t.L(), c, roachNodes, mixedversion.NeverUseFixtures,
mixedversion.ClusterSettingOption(install.ClusterSettingsOption(settings.ClusterSettings)),
mixedversion.ClusterSettingOption(
install.ClusterSettingsOption(settings.ClusterSettings),
// In 23.1, the `user_id` field was added to `system.web_sessions`.
// If the cluster is migrating to 23.1, auth-session login will not
// be aware of this new field and authentication will fail.
// TODO(DarrylWong): When 22.2 is no longer supported, we won't run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😸

// into the above issue anymore and can enable secure clusters.
install.SecureOption(false),
),
)
mvt.InMixedVersion("rebalance load run",
func(ctx context.Context, l *logger.Logger, r *rand.Rand, h *mixedversion.Helper) error {
Expand Down
Loading