Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: run rebalance/by-load/*/mixed-version on insecure mode #122187

Merged

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Apr 11, 2024

Authentication fails if migrating from 22.2 to 23.1. Disable secure mode to avoid failing the test on this unrelated issue.

Fixes: #122179
Fixes: #122084

Release note: None

Authentication fails if migrating from 22.2 to 23.1. Disable secure mode
to avoid failing the test on this unrelated issue.

Fixes: cockroachdb#122179
Fixes: cockroachdb#122084

Release note: None
@kvoli kvoli self-assigned this Apr 11, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. and removed backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Apr 11, 2024
@kvoli kvoli marked this pull request as ready for review April 11, 2024 14:17
@kvoli kvoli requested a review from a team as a code owner April 11, 2024 14:17
@kvoli kvoli requested review from herkolategan, renatolabs and DarrylWong and removed request for a team April 11, 2024 14:17
// In 23.1, the `user_id` field was added to `system.web_sessions`.
// If the cluster is migrating to 23.1, auth-session login will not
// be aware of this new field and authentication will fail.
// TODO(DarrylWong): When 22.2 is no longer supported, we won't run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😸

@kvoli
Copy link
Collaborator Author

kvoli commented Apr 11, 2024

bors r=DarrylWong

@kvoli
Copy link
Collaborator Author

kvoli commented Apr 11, 2024

TYFTR

@craig craig bot merged commit c6c9461 into cockroachdb:master Apr 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
3 participants