server: http requests always fallback to system tenant #120707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a default tenant was configured via the cluster setting, if that tenant was unavailable, all HTTP requests would fail if they did not specify an explicit tenant. This change allows HTTP requests to always fallback to the system tenant if the default tenant is not available, which allows for DB Console to be reached in these scenarios. Resolves: cockroachdb#120084 Epic: None Release note: None
dhartunian
requested review from
a team and
abarganier
and removed request for
a team
|
This change is |
abarganier
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dt)
|
TFTR. I think it's fine as-is because HTTP access to the system tenant is still fully gated behind authn/authz so our existing security policies should cover that. bors r=abarganier |
dt
approved these changes
Mar 20, 2024
|
Build failed (retrying...): |
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a default tenant was configured via the cluster setting, if that tenant was unavailable, all HTTP requests would fail if they did not specify an explicit tenant.
This change allows HTTP requests to always fallback to the system tenant if the default tenant is not available, which allows for DB Console to be reached in these scenarios.
Resolves: #120084
Epic: None
Release note: None