Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbconsole: unable to login to any tenant if default tenant is not active #120084

Closed
dt opened this issue Mar 7, 2024 · 0 comments · Fixed by #120707
Closed

dbconsole: unable to login to any tenant if default tenant is not active #120084

dt opened this issue Mar 7, 2024 · 0 comments · Fixed by #120707
Assignees
@dhartunian
Labels
A-observability-inf branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster P-1 Issues/test failures with a fix SLA of 1 month

Comments

@dt
Copy link
Member

dt commented Mar 7, 2024 •
edited by cockroach-jira-scripts
Loading

Expected: loading the db console would present a login page allowing logging in to one of the tenants -- the system tenant perhaps -- regardless of the value of the server.controller.default_tenant setting.

Actual behavior: the console does not load.

It appears that the page is failing to load when it get a 500 trying to load bundle.js.
Adding ?cluster=system or some other active cluster does not appear to fix this, since bundle.js is fetched without the ?cluster=x parameter.

bundle.js is available logged out, so it isn't clear why the default default tenant needs to be active to fetch it.

Steps to reproduce on a new crdb cluster:
SET CLUSTER SETTING server.controller.default_tenant.check_service.enabled = false
SET CLUSTER SETTING server.controller.default_tenant = 'doesnotexist'
Try to load the db console.

Jira issue: CRDB-36465
@dt dt added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 24.1 labels Mar 7, 2024
@dt dt added the O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster label Mar 7, 2024
@ajstorm ajstorm added the P-1 Issues/test failures with a fix SLA of 1 month label Mar 8, 2024
@dhartunian dhartunian mentioned this issue Mar 19, 2024
Merged
craig bot pushed a commit that referenced this issue Mar 20, 2024
@dhartunian
Merge #120707
5c26990 
120707: server: http requests always fallback to system tenant r=abarganier a=dhartunian

Previously, when a default tenant was configured via the cluster setting, if that tenant was unavailable, all HTTP requests would fail if they did not specify an explicit tenant.

This change allows HTTP requests to always fallback to the system tenant if the default tenant is not available, which allows for DB Console to be reached in these scenarios.

Resolves: #120084
Epic: None

Release note: None

Co-authored-by: David Hartunian <[email protected]>
@craig craig bot closed this as completed in 93ebf15 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhartunian dhartunian

Labels
A-observability-inf branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster P-1 Issues/test failures with a fix SLA of 1 month
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: http requests always fallback to system tenant dhartunian/cockroach
3 participants
@dt @dhartunian @ajstorm