Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincheck: do not run geos tests on Windows #118797

Merged
merged 1 commit into from
Feb 6, 2024
Merged

bincheck: do not run geos tests on Windows #118797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/release/bincheck/bincheck
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ EOF
diff -u expected actual

# Verify libgeos functionality on all platforms except MacOS ARM64 and Windows
if [[ $(uname -om) == "Darwin arm64" ]]; then
if [[ $(uname -om) == "Darwin arm64" || $(uname -o) == "Msys" ]]; then
echo "Skipping libgeos tests"
else
echo "Testing libgeos functionality"
Expand Down
2 changes: 0 additions & 2 deletions build/release/bincheck/download_binary.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ download_and_extract() {
else
curl -sSfL "${binary_url}" > cockroach.zip
7z e -omnt cockroach.zip
mkdir -p mnt/lib
mv mnt/*.dll mnt/lib/
fi

echo "Downloaded ${binary_url}"
Expand Down
Loading