Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincheck: do not run geos tests on Windows #118797

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

rail
Copy link
Member

@rail rail commented Feb 5, 2024

In #106642 we stopped shipping libgeos on Windows, but didn't update the bincheck test to reflect the change.

Epic: none
Release note: None

In cockroachdb#106642 we stopped shipping libgeos on Windows, but didn't update the
bincheck test to reflect the change.

Epic: none
Release note: None
@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-release T-release Release Engineering & Automation Team backport-23.2.x Flags PRs that need to be backported to 23.2. labels Feb 5, 2024
@rail rail requested a review from celiala February 5, 2024 23:49
@rail rail self-assigned this Feb 5, 2024
@rail rail requested a review from a team as a code owner February 5, 2024 23:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail
Copy link
Member Author

rail commented Feb 6, 2024

bors r=celiala

@craig
Copy link
Contributor

craig bot commented Feb 6, 2024

Build succeeded:

@craig craig bot merged commit 804d37e into cockroachdb:master Feb 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release backport-23.2.x Flags PRs that need to be backported to 23.2. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-release Release Engineering & Automation Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants