util/span: use bazel for codegen, regenerate #118490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#110516, the code started used a generated btree. Unfortunately, the code did not adopt bazel code generation, so missed a regeneration when the changes in cockroachdb#116663 merged. Also, it seems, the change rotted such that regenerating didn't work because the entry was renamed from `frontierEntry` to `btreeFrontierEntry` without updating the go:generate comment. I imagine somebody did a manual rename. This fixes the problem by adopting bazel generation. Epic: None Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jan 30, 2024
Relates to cockroachdb#118490. Epic: None Release note: None
|
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
For whatever reason, the linter is unhappy that this package does not have a comment. I don't know how we avoided this failure in the past, but maybe it's being triggered by the fact that I'm changing the package? Epic: none Release note: None
ajwerner
force-pushed
the
adopt-btree-changes-and-bazel
branch
from
3953a63 to
d855875
Compare
|
@miretskiy can you stamp this? |
rickystewart
approved these changes
Jan 30, 2024
miretskiy
approved these changes
Jan 30, 2024
|
Bors r+ |
|
Build succeeded: |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jan 31, 2024
Relates to cockroachdb#118490. Epic: None Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 2, 2024
118491: util/interval: update doc.go for bazel r=yuzefovich a=ajwerner Relates to #118490. Epic: None Release note: None 118719: Storage: show in logs when crdb_internal.compact_engine_span is called #111954 r=raduberinde a=Manish4044 **Fixes**: #111954 **Description** This PR introduces log entries to indicate when crdb_internal.compact_engine_span is called. This improvement aims to facilitate debugging escalations. **Changes** Adding log statements whenever crdb_internal.compact_engine_span builtin is called Release Note: None Epic: none Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Manish Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #110516, the code started used a generated btree. Unfortunately, the code did not adopt bazel code generation, so missed a regeneration when the changes in #116663 merged.
Also, it seems, the change rotted such that regenerating didn't work because the entry was renamed from
frontierEntrytobtreeFrontierEntrywithout updating the go:generate comment. I imagine somebody did a manual rename.This fixes the problem by adopting bazel generation.
Epic: None
Release note: None