sql: permit non-synthetic future time AOST queries #117098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvanbenschoten
requested review from
michae2 and
miretskiy
and removed request for
a team
|
This change is |
Informs cockroachdb#101938. This commit removes the restriction that future-time AOST queries must use "synthetic" timestamps. This restriction was introduced back when it was unsafe for requests to operate at future timestamps unless they were marked as synthetic. This is no longer the case. It is important that we allow this, because future-time queries can issue subqueries with AOST timestamps (e.g. for SQL leasing with the "count-leases" internal executor use). Requests that are too far in the future will still be rejected during range lease checks. For details, see `Replica.checkRequestTimeRLocked`. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/sqlFutureTs
branch
from
28d6800 to
f719e85
Compare
michae2
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
TFTR! bors r=michae2 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #101938.
This commit removes the restriction that future-time AOST queries must use "synthetic" timestamps. This restriction was introduced back when it was unsafe for requests to operate at future timestamps unless they were marked as synthetic. This is no longer the case. It is important that we allow this, because future-time queries can issue subqueries with AOST timestamps (e.g. for SQL leasing with the "count-leases" internal executor use).
Requests that are too far in the future will still be rejected during range lease checks. For details, see
Replica.checkRequestTimeRLocked.Release note: None