kv/closedts: remove use and propagation of synthetic timestamp bit #117016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/synTimestampClosedTs
branch
from
65c5baf to
333f79a
Compare
|
Rebasing on #117098 to fix CI. |
nvanbenschoten
force-pushed
the
nvanbenschoten/synTimestampClosedTs
branch
from
333f79a to
d2a8f00
Compare
nvanbenschoten
requested review from
mgartner and
jayshrivastava
and removed request for
a team
Informs cockroachdb#101938. This commit removes the handling of synthetic timestamps from the closed timestamp tracker data structure. This flag has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. It does not need to be propagated from evaluating requests to the closed timestamp. Release note: None
Informs cockroachdb#101938. This commit stops setting the synthetic timestamp bit on the closed timestamps selected for ranges with a LEAD_FOR_GLOBAL_READS closed timestamp policy. This flag has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. It does not need to be propagated from evaluating requests to the closed timestamp. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/synTimestampClosedTs
branch
from
d2a8f00 to
e8440fc
Compare
erikgrinaker
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jayshrivastava and @mgartner)
|
TFTR! bors r+ |
|
Build succeeded! And happy new year! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #101938.
This PR removes the handling of synthetic timestamps from the closed timestamp tracker data structure.
It then stops setting the synthetic timestamp bit on the closed timestamps selected for ranges with a
LEAD_FOR_GLOBAL_READSclosed timestamp policy.This flag has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. It does not need to be propagated from evaluating requests to the closed timestamp.
Release note: None