-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: add replica pointer tag #11683
storage: add replica pointer tag #11683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although is this intended to be kept permanently?
Reviewed 2 of 2 files at r1. pkg/storage/replica.go, line 576 at r1 (raw file):
not %p? Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. pkg/storage/replica.go, line 576 at r1 (raw file): Previously, tamird (Tamir Duberstein) wrote…
I don't want the Comments from Reviewable |
I'm not sure. After debugging #11591, if this appears too verbose I'm not opposed to removing it. |
Review status: all files reviewed at latest revision, 1 unresolved discussion. pkg/storage/replica.go, line 576 at r1 (raw file): Previously, petermattis (Peter Mattis) wrote…
OK. https://golang.org/pkg/fmt/ doesn't seem to document the behaviour of Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. pkg/storage/replica.go, line 576 at r1 (raw file): Previously, tamird (Tamir Duberstein) wrote…
Hmm. It definitely works (I tested it). Comments from Reviewable |
Debugging aid for cockroachdb#11591.
aa229e8
to
a0d3054
Compare
LGTM. |
Debugging aid for #11591.
This change is