You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Goroutine stack traces include the argument values of the calls (see https://www.goinggo.net/2015/01/stack-traces-in-go.html). It seems feasible to pass the range ID as an argument to a handful of the Replica entry points in order to include the range ID in stack traces. The benefit of doing this is to more easily tie specific stack traces to log messages. After #11683 goes in this benefit may be diminished somewhat, but it still seems worth investigating.
Entry points that seem worth annotating are Replica.withRaftGroupLocked and Replica.add{Admin,Readonly,Write}Cmd.
The text was updated successfully, but these errors were encountered:
Goroutine stack traces include the argument values of the calls (see https://www.goinggo.net/2015/01/stack-traces-in-go.html). It seems feasible to pass the range ID as an argument to a handful of the
Replica
entry points in order to include the range ID in stack traces. The benefit of doing this is to more easily tie specific stack traces to log messages. After #11683 goes in this benefit may be diminished somewhat, but it still seems worth investigating.Entry points that seem worth annotating are
Replica.withRaftGroupLocked
andReplica.add{Admin,Readonly,Write}Cmd
.The text was updated successfully, but these errors were encountered: