Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: investigate including range ID in replica stack traces #11684

Closed
petermattis opened this issue Nov 29, 2016 · 0 comments
Closed

storage: investigate including range ID in replica stack traces #11684

petermattis opened this issue Nov 29, 2016 · 0 comments
Assignees
Milestone

Comments

@petermattis
Copy link
Collaborator

Goroutine stack traces include the argument values of the calls (see https://www.goinggo.net/2015/01/stack-traces-in-go.html). It seems feasible to pass the range ID as an argument to a handful of the Replica entry points in order to include the range ID in stack traces. The benefit of doing this is to more easily tie specific stack traces to log messages. After #11683 goes in this benefit may be diminished somewhat, but it still seems worth investigating.

Entry points that seem worth annotating are Replica.withRaftGroupLocked and Replica.add{Admin,Readonly,Write}Cmd.

@petermattis petermattis added this to the Later milestone Feb 23, 2017
@craig craig bot closed this as completed in 20db4ad Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants