Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-23.1: jobs: only store 23.1 debugging info after 23.1 upgrade #113910

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

dt
Copy link
Member

@dt dt commented Nov 6, 2023

Just the last commit of #113864 more or less.

Release note: none.
Epic: none.

@dt dt requested review from adityamaru and miretskiy November 6, 2023 23:14
@dt dt requested review from a team as code owners November 6, 2023 23:14
@dt dt requested review from rharding6373 and removed request for a team November 6, 2023 23:14
Copy link

blathers-crl bot commented Nov 6, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt force-pushed the backport-113864-commit-3 branch from 719b254 to c96f5b3 Compare November 7, 2023 02:31
@dt
Copy link
Member Author

dt commented Nov 7, 2023

Are all of the changes protected via a flag or option, new syntax, an environment variable or default-disabled cluster setting?

No, it's a bug fix.

What are the risks to backporting this change?

minimal - it wraps code that was always on in version gates so it is now always on only after upgrade.

Can the risks of backporting be mitigated?

No.

What are the risks to not backporting?

#113795

Does this change really need to be backported? Or can it reasonably wait until the next major release to be addressed?

partially fixes a regression in 23.1.11 that if unfixed is very bad for upgrades.

@dt dt merged commit 987946d into cockroachdb:release-23.1 Nov 7, 2023
2 checks passed
@dt
Copy link
Member Author

dt commented Nov 7, 2023

blathers backport 23.1.12-rc.FROZEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants