Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachtest: fix javascript installation commands #113618

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 1, 2023

Backport 1/1 commits from #113593 on behalf of @rafiss.

/cc @cockroachdb/release


Once again, the "proper" way to install nodejs has changed. This new way uses the latest instructions from https://github.com/nodesource/distributions

fixes #113588
fixes #113578
fixes #113569
fixes #113560
fixes #113586
fixes #113606
fixes #113607
fixes #113606
fixes #113604
fixes #113603
fixes #113614

Release note: None


Release justification: test only change

Once again, the "proper" way to install nodejs has changed. This new way
uses the latest instructions from https://github.com/nodesource/distributions

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 1, 2023 19:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-113593 branch from 56c42e2 to 5cb186c Compare November 1, 2023 19:17
@blathers-crl blathers-crl bot requested review from herkolategan and renatolabs and removed request for a team November 1, 2023 19:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 1, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-113593 branch from a07a438 to 049b3d5 Compare November 1, 2023 19:17
Copy link
Author

blathers-crl bot commented Nov 1, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from annrpom, srosenberg and a team November 1, 2023 19:17
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 1, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 9e41a51 into release-23.1 Nov 1, 2023
2 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.1-113593 branch November 1, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants