-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: fix javascript installation commands #113593
Conversation
Once again, the "proper" way to install nodejs has changed. This new way uses the latest instructions from https://github.com/nodesource/distributions Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, the "proper" way to install nodejs has changed
🥲 - does "setup_18.x" imply that we should also set NODE_MAJOR=18?
I added that to the URL explicitly, so instead of
we use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah - i can't read! lgtm
tftr! bors r+ |
Build succeeded: |
Once again, the "proper" way to install nodejs has changed. This new way uses the latest instructions from https://github.com/nodesource/distributions
fixes #113588
fixes #113578
fixes #113569
fixes #113560
fixes #113586
fixes #113606
fixes #113607
fixes #113606
fixes #113604
fixes #113603
fixes #113614
Release note: None