Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix javascript installation commands #113593

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 1, 2023

Once again, the "proper" way to install nodejs has changed. This new way uses the latest instructions from https://github.com/nodesource/distributions

fixes #113588
fixes #113578
fixes #113569
fixes #113560
fixes #113586
fixes #113606
fixes #113607
fixes #113606
fixes #113604
fixes #113603
fixes #113614

Release note: None

Once again, the "proper" way to install nodejs has changed. This new way
uses the latest instructions from https://github.com/nodesource/distributions

Release note: None
@rafiss rafiss added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Nov 1, 2023
@rafiss rafiss requested review from annrpom and a team November 1, 2023 16:27
@rafiss rafiss requested review from a team as code owners November 1, 2023 16:27
@rafiss rafiss requested review from herkolategan and srosenberg and removed request for a team November 1, 2023 16:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, the "proper" way to install nodejs has changed

🥲 - does "setup_18.x" imply that we should also set NODE_MAJOR=18?

@rafiss
Copy link
Collaborator Author

rafiss commented Nov 1, 2023

I added that to the URL explicitly, so instead of

NODE_MAJOR=20
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | sudo tee /etc/apt/sources.list.d/nodesource.list

we use

echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" | sudo tee /etc/apt/sources.list.d/nodesource.list

@rafiss rafiss requested a review from annrpom November 1, 2023 16:51
Copy link
Contributor

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah - i can't read! lgtm

@rafiss
Copy link
Collaborator Author

rafiss commented Nov 1, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 1, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
3 participants