-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: roachtest: bump GC TTL on source and dest tenant ranges for weekly roachtest #113589
Conversation
…achtest Previously, the kv50 weekly roachtest would take >4 hours, the default GC TTL, to complete replication and cutover. Thus, by the time fingerprinting would run some of the keys would already be under the GCThreshold before the FP machinery got a chance to write a PTS. To work around this we bump the GC TTL on the source and dest tenant ranges to 12 hours, the timeout of the roachtest. Fixes: #112823 Release note: None
61f221a
to
7a581de
Compare
61b3bf8
to
d37b834
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Reminder: it has been 3 weeks please merge or close your backport! |
Sorry I missed this. Seems reasonable to me if we still think it is important to backport. |
Reminder: it has been 3 weeks please merge or close your backport! |
Friendly ping: @stevendanna @msbutler is this something we want to merge? |
Reminder: it has been 3 weeks please merge or close your backport! |
@msbutler I think we haven't seen this fail in a while? Perhaps we just close it for now? |
sgtm |
Backport 1/1 commits from #113501 on behalf of @adityamaru.
/cc @cockroachdb/release
Previously, the kv50 weekly roachtest would take >4 hours, the default GC TTL, to complete replication and cutover. Thus, by the time fingerprinting would run some of the keys would already be under the GCThreshold before the FP machinery got a chance to write a PTS. To work around this we bump the GC TTL on the source and dest tenant ranges to 12 hours, the timeout of the roachtest.
Fixes: #112823
Release note: None
Release justification: Test-only change.