Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: roachtest: bump GC TTL on source and dest tenant ranges for weekly roachtest #113589

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 1, 2023

Backport 1/1 commits from #113501 on behalf of @adityamaru.

/cc @cockroachdb/release


Previously, the kv50 weekly roachtest would take >4 hours, the default GC TTL, to complete replication and cutover. Thus, by the time fingerprinting would run some of the keys would already be under the GCThreshold before the FP machinery got a chance to write a PTS. To work around this we bump the GC TTL on the source and dest tenant ranges to 12 hours, the timeout of the roachtest.

Fixes: #112823
Release note: None


Release justification: Test-only change.

…achtest

Previously, the kv50 weekly roachtest would take >4 hours,
the default GC TTL, to complete replication and cutover. Thus,
by the time fingerprinting would run some of the keys would
already be under the GCThreshold before the FP machinery got
a chance to write a PTS. To work around this we bump the
GC TTL on the source and dest tenant ranges to 12 hours, the
timeout of the roachtest.

Fixes: #112823
Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113501 branch from 61f221a to 7a581de Compare November 1, 2023 15:55
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 1, 2023 15:55
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113501 branch from 61b3bf8 to d37b834 Compare November 1, 2023 15:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 1, 2023
Copy link
Author

blathers-crl bot commented Nov 1, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 1, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@stevendanna
Copy link
Collaborator

Sorry I missed this. Seems reasonable to me if we still think it is important to backport.

Copy link

github-actions bot commented Jan 8, 2024

Reminder: it has been 3 weeks please merge or close your backport!

@yuzefovich
Copy link
Member

Friendly ping: @stevendanna @msbutler is this something we want to merge?

Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@stevendanna
Copy link
Collaborator

@msbutler I think we haven't seen this fail in a while? Perhaps we just close it for now?

@msbutler
Copy link
Collaborator

sgtm

@msbutler msbutler closed this Feb 21, 2024
@mgartner mgartner deleted the blathers/backport-release-23.2-113501 branch May 2, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants