Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: c2c/weekly/kv50 failed #112823

Closed
cockroach-teamcity opened this issue Oct 21, 2023 · 2 comments · Fixed by #113501
Closed

roachtest: c2c/weekly/kv50 failed #112823

cockroach-teamcity opened this issue Oct 21, 2023 · 2 comments · Fixed by #113501
Assignees
@adityamaru
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 21, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.c2c/weekly/kv50 failed with artifacts on master @ 07915532f9a7def000127029c667c3a91ce90e47:

	            	  | 	golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75
	            	Wraps: (2) monitor failure
	            	Wraps: (3) attached stack trace
	            	  -- stack trace:
	            	  | main.(*monitorImpl).Go.func1.1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:115
	            	  | runtime.gopanic
	            	  | 	GOROOT/src/runtime/panic.go:884
	            	  | main.(*testImpl).Fatalf
	            	  | 	main/pkg/cmd/roachtest/test_impl.go:311
	            	  | github.com/cockroachdb/cockroach/pkg/testutils/sqlutils.(*Row).Scan
	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/sqlutils/sql_runner.go:270
	            	  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.(*replicationDriver).compareTenantFingerprintsAtTimestamp.func1
	            	  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cluster_to_cluster.go:761
	            	  | main.(*monitorImpl).Go.func1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:119
	            	  | golang.org/x/sync/errgroup.(*Group).Go.func1
	            	  | 	golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75
	            	Wraps: (4) monitor user task failed
	            	Wraps: (5) attached stack trace
	            	  -- stack trace:
	            	  | main.(*monitorImpl).Go.func1.1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:115
	            	  | runtime.gopanic
	            	  | 	GOROOT/src/runtime/panic.go:884
	            	  | main.(*testImpl).Fatalf
	            	  | 	main/pkg/cmd/roachtest/test_impl.go:311
	            	  | github.com/cockroachdb/cockroach/pkg/testutils/sqlutils.(*Row).Scan
	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/sqlutils/sql_runner.go:270
	            	  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.(*replicationDriver).compareTenantFingerprintsAtTimestamp.func1
	            	  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cluster_to_cluster.go:761
	            	  | main.(*monitorImpl).Go.func1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:119
	            	  | [...repeated from below...]
	            	Wraps: (6) attached stack trace
	            	  -- stack trace:
	            	  | main.init
	            	  | 	main/pkg/cmd/roachtest/monitor.go:94
	            	  | runtime.doInit
	            	  | 	GOROOT/src/runtime/proc.go:6542
	            	  | runtime.main
	            	  | 	GOROOT/src/runtime/proc.go:233
	            	  | runtime.goexit
	            	  | 	src/runtime/asm_amd64.s:1598
	            	Wraps: (7) t.Fatal() was called
	            	Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *withstack.withStack (4) *errutil.withPrefix (5) *withstack.withStack (6) *withstack.withStack (7) *errutil.leafError
	Test:       	c2c/weekly/kv50
(require.go:1360).NoError: FailNow called
(monitor.go:153).Wait: monitor failure: monitor user task failed: t.Fatal() was called
test artifacts and logs in: /artifacts/c2c/weekly/kv50/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=aws , ROACHTEST_cpu=8 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Grafana is not yet available for aws clusters

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-32617
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Oct 21, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Oct 21, 2023
@adityamaru adityamaru self-assigned this Oct 23, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.c2c/weekly/kv50 failed with artifacts on master @ aa85c69776da942b4d539891725b780ba995401e:

	            	Wraps: (3) attached stack trace
	            	  -- stack trace:
	            	  | main.(*monitorImpl).Go.func1.1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:115
	            	  | runtime.gopanic
	            	  | 	GOROOT/src/runtime/panic.go:914
	            	  | main.(*testImpl).Fatalf
	            	  | 	main/pkg/cmd/roachtest/test_impl.go:311
	            	  | github.com/cockroachdb/cockroach/pkg/testutils/sqlutils.(*Row).Scan
	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/sqlutils/sql_runner.go:270
	            	  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.(*replicationDriver).compareTenantFingerprintsAtTimestamp.func1
	            	  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cluster_to_cluster.go:761
	            	  | main.(*monitorImpl).Go.func1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:119
	            	  | golang.org/x/sync/errgroup.(*Group).Go.func1
	            	  | 	golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75
	            	Wraps: (4) monitor user task failed
	            	Wraps: (5) attached stack trace
	            	  -- stack trace:
	            	  | main.(*monitorImpl).Go.func1.1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:115
	            	  | runtime.gopanic
	            	  | 	GOROOT/src/runtime/panic.go:914
	            	  | main.(*testImpl).Fatalf
	            	  | 	main/pkg/cmd/roachtest/test_impl.go:311
	            	  | github.com/cockroachdb/cockroach/pkg/testutils/sqlutils.(*Row).Scan
	            	  | 	github.com/cockroachdb/cockroach/pkg/testutils/sqlutils/sql_runner.go:270
	            	  | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.(*replicationDriver).compareTenantFingerprintsAtTimestamp.func1
	            	  | 	github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cluster_to_cluster.go:761
	            	  | main.(*monitorImpl).Go.func1
	            	  | 	main/pkg/cmd/roachtest/monitor.go:119
	            	  | [...repeated from below...]
	            	Wraps: (6) attached stack trace
	            	  -- stack trace:
	            	  | main.init
	            	  | 	main/pkg/cmd/roachtest/monitor.go:94
	            	  | runtime.doInit1
	            	  | 	GOROOT/src/runtime/proc.go:6757
	            	  | runtime.doInit
	            	  | 	GOROOT/src/runtime/proc.go:6724
	            	  | runtime.main
	            	  | 	GOROOT/src/runtime/proc.go:249
	            	  | runtime.goexit
	            	  | 	src/runtime/asm_amd64.s:1650
	            	Wraps: (7) t.Fatal() was called
	            	Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *withstack.withStack (4) *errutil.withPrefix (5) *withstack.withStack (6) *withstack.withStack (7) *errutil.leafError
	Test:       	c2c/weekly/kv50
(require.go:1360).NoError: FailNow called
(monitor.go:153).Wait: monitor failure: monitor user task failed: t.Fatal() was called
test artifacts and logs in: /artifacts/c2c/weekly/kv50/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=aws , ROACHTEST_cpu=8 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Grafana is not yet available for aws clusters

This test on roachdash | Improve this report!

@adityamaru
Copy link
Contributor

So we attempt to fingerprint from Saturday, October 28, 2023 7:12:32.546 AM but our GC has moved up to Saturday, October 28, 2023 7:12:35.342 AM. The fingerprinting started at 11:14:48 and with a default GC TTL of four hours its expected that 7:12:32 is eligible for GC. One solution here is to bump the GC TTL for the cluster to 6 hours to allow the fingerprint to complete.

@adityamaru adityamaru mentioned this issue Oct 31, 2023
Merged
craig bot pushed a commit that referenced this issue Nov 1, 2023
@adityamaru
Merge #113501
b22b3f1 
113501: roachtest: bump GC TTL on source and dest tenant ranges for weekly roachtest r=msbutler a=adityamaru

Previously, the kv50 weekly roachtest would take >4 hours, the default GC TTL, to complete replication and cutover. Thus, by the time fingerprinting would run some of the keys would already be under the GCThreshold before the FP machinery got a chance to write a PTS. To work around this we bump the GC TTL on the source and dest tenant ranges to 12 hours, the timeout of the roachtest.

Fixes: #112823
Release note: None

Co-authored-by: adityamaru <[email protected]>
@craig craig bot closed this as completed in f1937ec Nov 1, 2023
blathers-crl bot pushed a commit that referenced this issue Nov 1, 2023
@adityamaru
roachtest: bump GC TTL on source and dest tenant ranges for weekly ro…
d37b834 
…achtest

Previously, the kv50 weekly roachtest would take >4 hours,
the default GC TTL, to complete replication and cutover. Thus,
by the time fingerprinting would run some of the keys would
already be under the GCThreshold before the FP machinery got
a chance to write a PTS. To work around this we bump the
GC TTL on the source and dest tenant ranges to 12 hours, the
timeout of the roachtest.

Fixes: #112823
Release note: None
@blathers-crl blathers-crl bot mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityamaru adityamaru

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

roachtest: bump GC TTL on source and dest tenant ranges for weekly roachtest adityamaru/cockroach
2 participants
@adityamaru @cockroach-teamcity