sql: log non-internal errors for explain-redaction test

[DrewKimball]

This patch adds logging to TestExplainRedact and TestExplainRedactDDL in the case of non-internal errors, which were previously silently skipped. This should add visibility into the "leaked goroutine" test flakes that have been appearing in these tests.

Informs #112868

Release note: None

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[michae2]

Thank you! Just one suggestion.

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

---

pkg/sql/tests/explain_test_util.go line 99 at r1 (raw file):

										t.Error(err)
									} else {
										t.Logf("encountered non-internal error: %s\n", err)

The test doesn't bother to avoid doing silly things like EXPLAIN (OPT, JSON), so I suggest using a condition like } else if !strings.Contains(msg, "syntax error") { to keep syntax errors muted.

[DrewKimball]

TFTR!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

---

pkg/sql/tests/explain_test_util.go line 99 at r1 (raw file):

Previously, michae2 (Michael Erickson) wrote…

The test doesn't bother to avoid doing silly things like EXPLAIN (OPT, JSON), so I suggest using a condition like } else if !strings.Contains(msg, "syntax error") { to keep syntax errors muted.

Done.

[DrewKimball]

TFTR!

bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)