Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestExplainRedact failed #112868

Closed
cockroach-teamcity opened this issue Oct 23, 2023 · 2 comments
Closed

sql: TestExplainRedact failed #112868

cockroach-teamcity opened this issue Oct 23, 2023 · 2 comments
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 23, 2023 •
edited by cockroach-jira-scripts
Loading

sql.TestExplainRedact failed with artifacts on release-23.2 @ 11457b476f9a325cd32d402374d8469e2bc517bb:

        	4581:::INT8 AS col😉50,
        	(-2079088609):::INT8 AS col51,
        	tab16._int8 AS col52,
        	0.14296594667376372:::FLOAT8 AS c͜ol53,
        	timezone(NULL::STRING, tab16._timestamptz::TIMESTAMPTZ)::TIMESTAMP AS col54,
        	tab16._interval AS "c\\uB31Fol55",
        	false AS "c	ol56",
        	tab16._decimal AS " col57",
        	e'pterodactyl\x16Yukp@57':::STRING AS "Col58",
        	NULL AS "\\u7CD7c%qo\\U000BE752l̵\\uB8E659",
        	tab16._jsonb AS col60,
        	tab16._enum AS co̳l61
        FROM
        	defaultdb.public.seed@[0] AS tab16
    explain_test_util.go:39: INSERT
        INTO
        	defaultdb.public.seed AS tab17 (_int8, _float4, _timestamp, _decimal, _string, _jsonb)
        VALUES
        	(
        		9223372036854775807:::INT8,
        		(-1.9352527856826782):::FLOAT8,
        		'2026-11-15 04:31:29.000977':::TIMESTAMP,
        		(-53.89896636649043174):::DECIMAL,
        		'':::STRING,
        		'["V7Nt9wlR", false, "foobar"]':::JSONB
        	)
    explain_test_util.go:39: SELECT
        	"tab\\U000D377218"._float8 AS "coL62", '+Inf':::FLOAT8 AS "	col63", "tab\\U000D377218"._float8 AS "col	64"
        FROM
        	defaultdb.public.seed AS "tab\\U000D377218"
        	JOIN defaultdb.public.seed AS "ta\\uB2EFb19" ON
        			("tab\\U000D377218"._int8) = ("ta\\uB2EFb19"._int8)
        			AND ("tab\\U000D377218"._date) = ("ta\\uB2EFb19"._date)
        			AND ("tab\\U000D377218"._float8) = ("ta\\uB2EFb19"._float8)
        WHERE
        	NULL
        ORDER BY
        	"tab\\U000D377218"._float8 ASC NULLS LAST
    explain_test.go:559: -- test log scope end --
    explain_test.go:559: Leaked goroutine: goroutine 104623 [select]:
        github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker.func1()
        	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:171 +0x9c
        created by github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker
        	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:166 +0x64
        Leaked goroutine: goroutine 104624 [select]:
        github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker.func1()
        	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:171 +0x9c
        created by github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker
        	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:166 +0x64
--- FAIL: TestExplainRedact (53.93s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-32652
@cockroach-teamcity cockroach-teamcity added branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Oct 23, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Oct 23, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 23, 2023
@mgartner mgartner mentioned this issue Oct 23, 2023
Merged
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Oct 25, 2023
@DrewKimball
sql: log non-internal errors for explain-redaction test
be299d9 
This patch adds logging to `TestExplainRedact` and `TestExplainRedactDDL`
in the case of non-internal errors, which were previously silently skipped.
This should add visibility into the "leaked goroutine" test flakes that have
been appearing in these tests.

Informs cockroachdb#112868

Release note: None
@DrewKimball DrewKimball mentioned this issue Oct 25, 2023
Merged
@DrewKimball
Copy link
Collaborator

We suspect this is related to the test ignoring errors, and are adding logging to make it easier to debug. Since it seems like a test-only bug, removing the release-blocker label.

@DrewKimball DrewKimball removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Oct 26, 2023
DrewKimball added a commit to DrewKimball/cockroach that referenced this issue Oct 26, 2023
@DrewKimball
sql: log non-internal errors for explain-redaction test
e54d705 
This patch adds logging to `TestExplainRedact` and `TestExplainRedactDDL`
in the case of non-internal errors, which were previously silently skipped.
This should add visibility into the "leaked goroutine" test flakes that have
been appearing in these tests.

Informs cockroachdb#112868

Release note: None
craig bot pushed a commit that referenced this issue Oct 27, 2023
@DrewKimball
Merge #113104
471f406 
113104: sql: log non-internal errors for explain-redaction test r=DrewKimball a=DrewKimball

This patch adds logging to `TestExplainRedact` and `TestExplainRedactDDL` in the case of non-internal errors, which were previously silently skipped. This should add visibility into the "leaked goroutine" test flakes that have been appearing in these tests.

Informs #112868

Release note: None

Co-authored-by: Drew Kimball <[email protected]>
@DrewKimball
Copy link
Collaborator

We'll wait for this to trigger again with the extra logging.

@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.2
Development

No branches or pull requests
2 participants
@cockroach-teamcity @DrewKimball