Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: roachprod: remove WaitDelay call in localSession #112764

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 20, 2023

Backport 1/1 commits from #112714 on behalf of @renatolabs.

/cc @cockroachdb/release


This call was added during work on #111064 as an attempt to fix issues during development. It should not be needed for correctness. It also makes backporting that work to 23.1 not possible, since the WaitDelay API was introduced in Go 1.20.

Epic: none

Release note: None


Release justification: test-only change.

This call was added during work on #111064 as an attempt to fix issues
during development. It should not be needed for correctness. It also
makes backporting that work to 23.1 not possible, since the
`WaitDelay` API was introduced in Go 1.20.

Epic: none

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 20, 2023 17:06
@blathers-crl blathers-crl bot requested review from herkolategan and removed request for a team October 20, 2023 17:06
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-112714 branch from d2d6f89 to 7462102 Compare October 20, 2023 17:06
@blathers-crl blathers-crl bot requested a review from DarrylWong October 20, 2023 17:06
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 20, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-112714 branch from e17eab7 to 1f47a2a Compare October 20, 2023 17:06
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 20, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@renatolabs renatolabs merged commit d6a6000 into release-23.2 Oct 20, 2023
2 checks passed
@renatolabs renatolabs deleted the blathers/backport-release-23.2-112714 branch October 20, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants