Skip to content

Commit

Permalink
roachprod: remove WaitDelay call in localSession
Browse files Browse the repository at this point in the history
This call was added during work on #111064 as an attempt to fix issues
during development. It should not be needed for correctness. It also
makes backporting that work to 23.1 not possible, since the
`WaitDelay` API was introduced in Go 1.20.

Epic: none

Release note: None
  • Loading branch information
renatolabs committed Oct 19, 2023
1 parent d2d6f89 commit 1f47a2a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/roachprod/install/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"os/exec"
"path/filepath"
"sync"
"time"

"github.com/cockroachdb/cockroach/pkg/roachprod/config"
rperrors "github.com/cockroachdb/cockroach/pkg/roachprod/errors"
Expand Down Expand Up @@ -246,7 +245,6 @@ type localSession struct {
func newLocalSession(cmd string) *localSession {
ctx, cancel := context.WithCancel(context.Background())
fullCmd := exec.CommandContext(ctx, "/bin/bash", "-c", cmd)
fullCmd.WaitDelay = time.Second
return &localSession{fullCmd, cancel}
}

Expand Down

0 comments on commit 1f47a2a

Please sign in to comment.