Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamingccl: skip TestStreamingRegionalConstraint #112694

Closed
wants to merge 1 commit into from
Closed

streamingccl: skip TestStreamingRegionalConstraint #112694

wants to merge 1 commit into from

Conversation

stevendanna
Copy link
Collaborator

Informs #112541

Release note: None

@stevendanna stevendanna requested a review from a team as a code owner October 19, 2023 16:17
@stevendanna stevendanna requested review from adityamaru and removed request for a team October 19, 2023 16:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna
Copy link
Collaborator Author

This might not be needed. It's possible the places we've seen this just haven't yet gotten #112597

@adityamaru
Copy link
Contributor

adityamaru commented Oct 19, 2023 •
edited
Loading

nah i think I see this 3m45 sec timeout also not being enough: condition failed to evaluate within 3m45s: from replication_stream_e2e_test.go:1207: running iterate callback: found table data located on another node 3 😢 https://teamcity.cockroachdb.com/viewLog.html?buildId=12260852&buildTypeId=Cockroach_BazelExtendedCi

cc: @msbutler

@adityamaru
Copy link
Contributor

flake is unrelated

bors r=adityamaru

@adityamaru
Copy link
Contributor

sorry i didnt see the conversation on the other issue. I will wait to get confirmation we want this.

bors r-

@craig
Copy link
Contributor

craig bot commented Oct 19, 2023

Canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamaru adityamaru adityamaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevendanna @cockroach-teamcity @adityamaru