streamingst: increase timeout on TestStreamingRegionalConstraint #112597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs cockroachdb#111541 Release note: none
|
This change is |
msbutler
requested review from
dt and
stevendanna
and removed request for
a team and
dt
RaduBerinde
approved these changes
Oct 18, 2023
kvoli
approved these changes
Oct 18, 2023
|
Is there no option other than giving each of these lines 3.75 minutes to succeed? I'm worried this is going to contribute non-trivially to overall CI time. |
|
bors p=99 |
|
I wonder if there's something else going on. I'm seeing a couple other tests time out (and it's unlikely it's caused by my change): |
|
bors r+ p=99 |
|
Build succeeded: |
This was referenced Oct 19, 2023
|
blathers backport 23.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #111541
Release note: none