Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: backport changes to roachtest build scripts #112562

Merged
merged 2 commits into from
Oct 18, 2023
Merged

release-23.1: backport changes to roachtest build scripts #112562

merged 2 commits into from
Oct 18, 2023

Conversation

RaduBerinde
Copy link
Member

Backport:

Release justification: test-only change, keep roachtest scripts in sync

Please see individual PRs for details.

/cc @cockroachdb/release

@RaduBerinde
build: add roachtest nightlies coverage scripts
17892d9 
This script will be used in a coverage build that runs the nightlies
on GCE and collects coverage data.

Epic: none
Release note: None
@RaduBerinde
build: improve roachtest build scripts
cd537e1 
We improve the roachtest scripts to support building finer-grained
components: the `roachtest_compile_component.sh` script builds a
single component (cockroach, cockroach-ea, workload, libgeos,
roachtest). For each component we define the bazel arguments and build
products, minimizing duplication of other code. There should be no
functional changes.

Epic: none
Release note: None
@RaduBerinde RaduBerinde requested review from a team and removed request for a team October 17, 2023 19:07
@RaduBerinde RaduBerinde requested a review from a team as a code owner October 17, 2023 19:07
@blathers-crl
Copy link

blathers-crl bot commented Oct 17, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 17, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde merged commit 4afc8fe into cockroachdb:release-23.1 Oct 18, 2023
2 checks passed
@RaduBerinde RaduBerinde deleted the backport23.1-111382-111410 branch October 18, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan was automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaduBerinde @cockroach-teamcity @renatolabs