build: add roachtest nightlies coverage scripts #111382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
srosenberg
reviewed
Sep 28, 2023
| ssh-keygen -q -C "roachtest-nightly-bazel $(date)" -N "" -f ~/.ssh/id_rsa | ||
| fi | ||
|
|
||
| $root/build/teamcity/cockroach/nightlies/roachtest_compile_bits.sh --with-code-coverage amd64 |
There was a problem hiding this comment.
Might be worth a comment to emphasize that the hardcoded (target) architecture is not actually preventing TC agent from running arm64, since it's going to be cross-built.
This script will be used in a coverage build that runs the nightlies on GCE and collects coverage data. Epic: none Release note: None
RaduBerinde
force-pushed
the
roachtest-cover-scripts
branch
from
0b75185 to
c8db151
Compare
RaduBerinde
commented
Sep 28, 2023
There was a problem hiding this comment.
TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @smg260 and @srosenberg)
build/teamcity/cockroach/coverage/roachtest_nightly_gce_impl.sh line 13 at r1 (raw file):
Previously, srosenberg (Stan Rosenberg) wrote…
Might be worth a comment to emphasize that the hardcoded (target) architecture is not actually preventing TC agent from running arm64, since it's going to be cross-built.
Done.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script will be used in a coverage build that runs the nightlies
on GCE and collects coverage data.
Epic: none
Release note: None