release-23.1: roachtest: tpcc: don't look at cloud during registration #112553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #111285.
/cc @cockroachdb/release
Release justification: test-only change
This commit cleans up the tpcc code to not look at the cloud (leaked through
TestSpec
) during registration. Instead, we define both GCE and AWS values in the spec and decide between them when the test is run.Informs #104029
Release note: None