roachtest: tpcc: don't look at cloud during registration #111285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduBerinde
requested review from
smg260,
DarrylWong and
srosenberg
and removed request for
a team
|
This change is |
|
Started some test runs ("tpcc" filter): https://teamcity.cockroachdb.com/viewQueued.html?itemId=11939880 https://teamcity.cockroachdb.com/viewQueued.html?itemId=11939881 |
This commit cleans up the tpcc code to not look at the cloud (leaked through `TestSpec`) during registration. Instead, we define both GCE and AWS values in the spec and decide between them when the test is run. Informs cockroachdb#104029 Release note: None
RaduBerinde
force-pushed
the
tpcc-gce-aws
branch
from
4e1c89b to
8637378
Compare
srosenberg
approved these changes
Sep 26, 2023
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up the tpcc code to not look at the cloud (leaked through
TestSpec) during registration. Instead, we define both GCE and AWS values in the spec and decide between them when the test is run.Informs #104029
Release note: None