sql-telemetry: query_sampling.max_event_frequency public

[emilaleksanteri]

Epic: none
Fixes: #108385

Release note (sql change): make max_event_frequency public for public documentation

[cockroach-teamcity]

All committers have signed the CLA.

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

• Please ensure your git commit message contains a release note.
• When CI has completed, please ensure no errors have appeared.

I have added a few people who may be able to assist in reviewing:

• @florence-crl (author of Set public = t for sql.telemetry.query_sampling.max_event_frequency cluster setting #108385)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[florence-crl]

@maryliag please review or ask someone else to review to make sure the code change is correct. thanks!

[maryliag]

Hi @emilaleksanteri , thank you for your contribution!

You're missing an update on a generate file, to have the needed doc file updated you need to run ./dev gen, which will generate something similar to this other PR: https://github.com/cockroachdb/cockroach/pull/106530/files

Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @emilaleksanteri)

---

-- commits line 2 at r1:
We do have a format to commit messages, you need to add Fixes #108385 to this commit message and also a release note, similar to #106530

[emilaleksanteri]

Hi @emilaleksanteri , thank you for your contribution!

You're missing an update on a generate file, to have the needed doc file updated you need to run ./dev gen, which will generate something similar to this other PR: https://github.com/cockroachdb/cockroach/pull/106530/files

Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @emilaleksanteri)

-- commits line 2 at r1: We do have a format to commit messages, you need to add Fixes #108385 to this commit message and also a release note, similar to #106530

Oh right, sounds good, thank you!

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[emilaleksanteri]

Hi @emilaleksanteri , thank you for your contribution!

You're missing an update on a generate file, to have the needed doc file updated you need to run ./dev gen, which will generate something similar to this other PR: https://github.com/cockroachdb/cockroach/pull/106530/files

Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @emilaleksanteri)

-- commits line 2 at r1: We do have a format to commit messages, you need to add Fixes #108385 to this commit message and also a release note, similar to #106530

Hi @emilaleksanteri , thank you for your contribution!

You're missing an update on a generate file, to have the needed doc file updated you need to run ./dev gen, which will generate something similar to this other PR: https://github.com/cockroachdb/cockroach/pull/106530/files

Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @emilaleksanteri)

-- commits line 2 at r1: We do have a format to commit messages, you need to add Fixes #108385 to this commit message and also a release note, similar to #106530

Hi, it looks like there is something wrong with my ./dev gen builder on linux_amd64

GoCompilePkg pkg/ccl/gssapiccl/gssapiccl.a [for tool] failed: (Exit 1): builder failed: error executing command (from target //pkg/ccl/gssapiccl:gssapiccl) bazel-out/k8-opt-exec-2B5CBBC6/bin/external/go_sdk/builder_reset/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -tags bazel,gss,bazel,gss -src pkg/ccl/gssapiccl/get_user.go -src ... (remaining 53 arguments skipped)

Do you know if I need to do something with my bazel/bazelisk to make the gen work?

[rickystewart]

@emilaleksanteri

You should be able to reproduce the issue with bazel build pkg/gen:code. You get a better error message by adding the flag --verbose_failures.

From the beginning of the error message, I'm assuming it's going to be a resolv_wrapper link error. Consider using --config cross instead of --config dev (assuming you have the latter in your .bazelrc.user).

If you don't want to do that, installing the libresolv-wrapper package is an option. (If you are on Ubuntu 22.04, this is not an option.)

Removing -lresolv_wrapper from pkg/ccl/gssapiccl/BUILD.bazel is another option.

[emilaleksanteri]

@rickystewart woohoo it worked, thank you very much! It was the .bazelrc.user

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

• We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
• When CI has completed, please ensure no errors have appeared.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[maryliag]

Awesome!

I'll go ahead and merge it!

bors r+

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @emilaleksanteri)

[emilaleksanteri]

@maryliag woohoo sounds good!!

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)