ui: set ui.display_timezone as public #106530
Conversation
Resolves: cockroachdb#106415 Epic: none Release note (ui change): The visibility of the cluster setting `ui.display_timezone` has been set to public. Documentation of the cluster setting has been added. No functionality has been changed.
|
This change is |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @zachlite)
-- commits line 7 at r1:
I think this should remain internal until a cluster setting that is capable of handling all the timezones is created. Only supporting 2 timezones will cause confusion and feature requests for other timezones. The current setting looks like it won't be the best user experience to support all possible timezones, so it will likely result in a breaking change for a better experience. Would it not be better till timezones are fully supported?
j82w
dismissed
their stale review
offline discussion, already publicly documented.
|
bors r+ |
|
Build succeeded: |
Resolves: #106415
Epic: none
Release note (ui change): The visibility of the cluster setting
ui.display_timezonehas been set to public. Documentation of the cluster setting has been added. No functionality has been changed.