Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: changefeedccl: ensure pubsub sink emits resolved messages to all topics #110871

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 19, 2023

Backport 1/1 commits from #110859 on behalf of @jayshrivastava.

/cc @cockroachdb/release


Previously, the pubsub sink would emit one resolved message with an empty
topic, causing an error. This change ensures that it emits resolved
messages to each topic and the topic string is not empty. This behavior
aligns with what the old, now deprecated, pubsub sink.

Fixes: #110637
Release note: None


Release justification: important bug fix.

Previously, the pubsub sink would emit one resolved message with an empty
topic, causing an error. This change ensures that it emits resolved
messages to each topic and the topic string is not empty. This behavior
aligns with what the old, now deprecated, pubsub sink.

Fixes: #110637
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 19, 2023 04:37
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110859 branch from 66cd84c to 08c8671 Compare September 19, 2023 04:37
@blathers-crl blathers-crl bot requested review from jayshrivastava and removed request for a team September 19, 2023 04:37
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 19, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110859 branch from 8a38035 to a042242 Compare September 19, 2023 04:37
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 19, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 19, 2023
@blathers-crl blathers-crl bot requested a review from miretskiy September 19, 2023 04:37
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jayshrivastava jayshrivastava merged commit 12e412d into release-23.1 Sep 19, 2023
2 checks passed
@jayshrivastava jayshrivastava deleted the blathers/backport-release-23.1-110859 branch September 19, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants