changefeedccl: ensure pubsub sink emits resolved messages to all topics #110859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jayshrivastava
force-pushed
the
debug-pubsub-sink
branch
2 times, most recently
from
f99b8e6 to
6654989
Compare
jayshrivastava
changed the title
jayshrivastava
requested review from
miretskiy
and removed request for
a team
miretskiy
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava)
pkg/ccl/changefeedccl/changefeed_processors.go line 1096 at r1 (raw file):
cf.freqEmitResolved = emitNoResolved }
nit: probably not needed to be included in this pr.
Previously, the pubsub sink would emit one resolved message with an empty topic, causing an error. This change ensures that it emits resolved messages to each topic and the topic string is not empty. This behavior aligns with what the old, now deprecated, pubsub sink. Fixes: cockroachdb#110637 Release note: None
jayshrivastava
force-pushed
the
debug-pubsub-sink
branch
from
6654989 to
b92e292
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the pubsub sink would emit one resolved message with an empty
topic, causing an error. This change ensures that it emits resolved
messages to each topic and the topic string is not empty. This behavior
aligns with what the old, now deprecated, pubsub sink.
Fixes: #110637
Release note: None